Skip to content

Add additional capability handling opts#3099

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:export-caps
Mar 15, 2019
Merged

Add additional capability handling opts#3099
crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael:export-caps

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

And it even works for Windows creating LCOW specs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3099 into master will decrease coverage by 3.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3099      +/-   ##
==========================================
- Coverage   47.34%   43.59%   -3.76%     
==========================================
  Files          93      104      +11     
  Lines        8556    11135    +2579     
==========================================
+ Hits         4051     4854     +803     
- Misses       3777     5545    +1768     
- Partials      728      736       +8
Flag Coverage Δ
#linux 47.57% <100%> (+0.23%) ⬆️
#windows 40.47% <100%> (?)
Impacted Files Coverage Δ
oci/spec_opts.go 30.23% <100%> (+3.4%) ⬆️
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef45e4f...bdd84ab. Read the comment docs.

@crosbymichael crosbymichael merged commit c60a5fd into containerd:master Mar 15, 2019
@crosbymichael crosbymichael deleted the export-caps branch March 15, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants