Skip to content

Makefile: allow overriding package name#3096

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:override_package_name
Mar 14, 2019
Merged

Makefile: allow overriding package name#3096
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:override_package_name

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 14, 2019

With this patch applied, the package-name in the --version output can be overridden;

make PACKAGE=containerd.io binaries

./bin/containerd --version
containerd containerd.io v1.2.0-329-ga15b6e20.m a15b6e2097c48b632dbdc63254bad4c62b69e709.m

@thaJeztah
Makefile: allow overriding package name
b858cfb 
With this patch applied, the package-name in the `--version` output can be overridden;

    make PACKAGE=containerd.io binaries

    ./bin/containerd --version
    containerd containerd.io v1.2.0-329-ga15b6e20.m a15b6e2.m

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 14, 2019

@seemethere @dmcgowan ptal

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 14, 2019 •
edited
Loading

Codecov Report

Merging #3096 into master will decrease coverage by 7.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
- Coverage   47.35%   40.24%   -7.12%     
==========================================
  Files          93       74      -19     
  Lines        8555     9838    +1283     
==========================================
- Hits         4051     3959      -92     
- Misses       3776     5316    +1540     
+ Partials      728      563     -165
Flag Coverage Δ
#linux ?
#windows 40.24% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 1.79% <0%> (-51.25%) ⬇️
archive/tar.go 16.99% <0%> (-33.86%) ⬇️
metadata/snapshot.go 21.53% <0%> (-33.23%) ⬇️
cio/io.go 1.52% <0%> (-25.75%) ⬇️
content/local/writer.go 56.86% <0%> (-7.34%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed2c0a...b858cfb. Read the comment docs.

@thaJeztah thaJeztah mentioned this pull request Mar 14, 2019
Merged
3 tasks
@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Mar 14, 2019

LGTM

1 similar comment
@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Mar 14, 2019

LGTM

@dmcgowan dmcgowan merged commit 63d7a9c into containerd:master Mar 14, 2019
@thaJeztah thaJeztah deleted the override_package_name branch March 14, 2019 23:13
This was referenced Mar 14, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @codecov-io @crosbymichael @dmcgowan