Skip to content

BUILDING.md: update testing section#3070

Merged
estesp merged 1 commit intocontainerd:masterfrom
darfux:update-build-doc
Mar 6, 2019
Merged

BUILDING.md: update testing section#3070
estesp merged 1 commit intocontainerd:masterfrom
darfux:update-build-doc

Conversation

@darfux
Copy link
Copy Markdown
Contributor

@darfux darfux commented Mar 6, 2019

The integration-parallel has been removed by 4df7075.
Update Makefile targets in BUILDING.md.

Signed-off-by: Li Yuxuan [email protected]

The integration-parallel has been removed by
containerd@4df7075.
Update Makefile targets in BUILDING.md.

Signed-off-by: Li Yuxuan <[email protected]>
@Ace-Tang
Copy link
Copy Markdown
Contributor

Ace-Tang commented Mar 6, 2019

Still test case in #2835 failed. @darfux , please re-trigger the ci to make it pass

@darfux darfux closed this Mar 6, 2019
@darfux darfux reopened this Mar 6, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 6, 2019

Codecov Report

Merging #3070 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3070   +/-   ##
=======================================
  Coverage   43.46%   43.46%           
=======================================
  Files         103      103           
  Lines       11033    11033           
=======================================
  Hits         4795     4795           
  Misses       5503     5503           
  Partials      735      735
Flag Coverage Δ
#linux 47.48% <ø> (ø) ⬆️
#windows 40.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70a530...4d2a26d. Read the comment docs.

@darfux
Copy link
Copy Markdown
Contributor Author

darfux commented Mar 6, 2019

Still test case in #2835 failed. @darfux , please re-trigger the ci to make it pass

@Ace-Tang thanks, I have re-triggered it 😄

@Ace-Tang
Copy link
Copy Markdown
Contributor

Ace-Tang commented Mar 6, 2019

Look good to me.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit bfbd1d0 into containerd:master Mar 6, 2019
@darfux darfux deleted the update-build-doc branch March 6, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants