Use unix.SignalNum in ParseSignal on unix platform#3063
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Mar 4, 2019
Merged
Use unix.SignalNum in ParseSignal on unix platform#3063crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael merged 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Shengjing Zhu <[email protected]>
Contributor
Author
|
Just noted, currently containerd still can't build on mipsx, since the vendored docker/docker is too old. I'm not confident to update the docker/docker vendor right now. But it builds with |
This removes the signalMap on unix platform, since the signalMap on different architectures is not same, especially it's wrong on mipsx. golang.org/x/sys/unix now has a SignalNum func to convert signal name to a number, thus there's no need to keep this redundant map. Windows platform still needs to have a signalMap, since golang.org/x/sys/windows doesn't have corresponding functions. Address: containerd#3061 Signed-off-by: Shengjing Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3063 +/- ##
=======================================
Coverage 43.87% 43.87%
=======================================
Files 102 102
Lines 10903 10903
=======================================
Hits 4784 4784
Misses 5384 5384
Partials 735 735
Continue to review full report at Codecov.
|
Contributor
|
Looks make sense on unix part |
Member
|
LGTM |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the signalMap on unix platform, since
the signalMap on different architectures is not same,
especially it's wrong on mipsx.
golang.org/x/sys/unix now has a SignalNum func to convert
signal name to a number, thus there's no need to keep
this redundant map.
Windows platform still needs to have a signalMap, since
golang.org/x/sys/windows doesn't have corresponding
functions.
Address: #3061