Fix a bug in shim log on Windows that can cause 100% CPU utilization#3050
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Feb 28, 2019
Merged
Fix a bug in shim log on Windows that can cause 100% CPU utilization#3050dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
With the change to unified shims (ie: 1 shim per multiple tasks) the shimLog on Windows for the 2nd-Nth worload containers will not have an associated named pipe listener. Due to a subtle bug in errors.Wrap passing a nil error we would unblock the disconnected listener and return 0 byte successfull reads which would cause go to continually read and cap the CPU. Signed-off-by: Justin Terry (VM) <[email protected]>
Contributor
Author
|
@jhowardmsft, @kevpar - FYI |
Codecov Report
@@ Coverage Diff @@
## master #3050 +/- ##
=======================================
Coverage 43.87% 43.87%
=======================================
Files 102 102
Lines 10903 10903
=======================================
Hits 4784 4784
Misses 5384 5384
Partials 735 735
Continue to review full report at Codecov.
|
Member
|
LGTM Does this solve the 100% CPU issue mentioned earlier? |
|
Yes. We are pretty certain this is the same root cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the change to unified shims (ie: 1 shim per multiple tasks) the shimLog
on Windows for the 2nd-Nth worload containers will not have an associated
named pipe listener.
Due to a subtle bug in errors.Wrap passing a nil error we would unblock the
disconnected listener and return 0 byte successfull reads which would cause go
to continually read and cap the CPU.
Signed-off-by: Justin Terry (VM) [email protected]