Skip to content

Conversation

@stefanberger
Copy link
Contributor

This PR adds the miscreant library for encrypting chunks of data using their StreamEncryptor/Decryptor. It also already adds the ReaderDigester interface that we will need for retrieving the digest of an encrypted layer. Then it adds the actual crypto code.

Signed-off-by: Stefan Berger <[email protected]>
Add a ReaderDigester interface that we will use for calculating
the digest on a layer that we are decryting while reading its
plain data from a Reader. The digest will be used in the OCI
Descriptor for identifying the layer.

Signed-off-by: Stefan Berger <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #3047 into master will increase coverage by 0.44%.
The diff coverage is 75.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
+ Coverage   43.87%   44.32%   +0.44%     
==========================================
  Files         102      104       +2     
  Lines       10903    11058     +155     
==========================================
+ Hits         4784     4901     +117     
- Misses       5384     5413      +29     
- Partials      735      744       +9
Flag Coverage Δ
#linux 47.91% <77.41%> (+0.42%) ⬆️
#windows 41.63% <75.48%> (+0.54%) ⬆️
Impacted Files Coverage Δ
content/content.go 0% <ø> (ø) ⬆️
images/encryption/blockcipher/blockcipher.go 69.44% <69.44%> (ø)
images/encryption/blockcipher/blockcipher_siv.go 77.31% <77.31%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f44ad0...115f096. Read the comment docs.

@lumjjb
Copy link
Contributor

lumjjb commented Jul 8, 2019

Could we close this in favor of #3134, Thanks!

@crosbymichael
Copy link
Member

@lumjjb done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants