Update go.etcd.io/bbolt to v1.3.2#3041
Conversation
Relevant changes: - ectd-io/bbolt#139 update the freelist readIDs - etcd-io/bbolt#140 add getFreePageIDs - etcd-io/bbolt#141 use segregated hashmap to boost the freelist allocate and release performance Signed-off-by: Sebastiaan van Stijn <[email protected]>
| // The alternative one is using hashmap, it is faster in almost all circumstances | ||
| // but it doesn't guarantee that it offers the smallest page id available. In normal case it is safe. | ||
| // The default type is array | ||
| FreelistType FreelistType |
There was a problem hiding this comment.
Looks like the default didn't change; no idea if changing is possible and/or if it would bring benefits in containerd?
There was a problem hiding this comment.
The default doesn't change yet, the new freelist type(hashmap) is experimental for now.
There was a problem hiding this comment.
The new freelist type will bring performance boost in almost all cases, especially when the dbsize is large
|
Considering the freelist change is opt in and experimental, so won't have an effect. Do any of the other changes have a positive effect on performance or stability? If it is just neutral we can update just to keep up to date, just want that to be clear. |
yes, so currently it's just neutral, so it would also make sense to hold off updating if there's no important stability fixes |
|
LGTM |
1 similar comment
|
LGTM |
full diff etcd-io/bbolt@v1.3.1-etcd.8...v1.3.2
Relevant changes: