Skip to content

runtime: allow specifying supported platforms with config#3033

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
tonistiigi:runtime-platforms
Feb 21, 2019
Merged

runtime: allow specifying supported platforms with config#3033
crosbymichael merged 1 commit intocontainerd:masterfrom
tonistiigi:runtime-platforms

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

Allow defining supported runtime platforms list from config as a node may support multiple.

@crosbymichael @dmcgowan

Signed-off-by: Tonis Tiigi [email protected]

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails due to the typo in func name.

Comment thread runtime/v2/manager_windows.go Outdated
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 20, 2019

Codecov Report

Merging #3033 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   43.96%   43.96%           
=======================================
  Files         102      102           
  Lines       10881    10881           
=======================================
  Hits         4784     4784           
  Misses       5362     5362           
  Partials      735      735
Flag Coverage Δ
#linux 47.58% <ø> (ø) ⬆️
#windows 41.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58dc067...b553a12. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@lowenna lowenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 31438b6 into containerd:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants