Skip to content

fixing typo and added a missing comment.#3030

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
veerun14:venuvvul/add-comments-fix-typos
Feb 19, 2019
Merged

fixing typo and added a missing comment.#3030
AkihiroSuda merged 1 commit intocontainerd:masterfrom
veerun14:venuvvul/add-comments-fix-typos

Conversation

@veerun14
Copy link
Copy Markdown

Signed-off-by: Veeraiah Chowdary Nuvvula [email protected]

Signed-off-by: Veeraiah Chowdary Nuvvula <[email protected]>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 18, 2019

Codecov Report

Merging #3030 into master will decrease coverage by 3.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
- Coverage   47.58%   43.96%   -3.62%     
==========================================
  Files          92      102      +10     
  Lines        8505    10881    +2376     
==========================================
+ Hits         4047     4784     +737     
- Misses       3731     5362    +1631     
- Partials      727      735       +8
Flag Coverage Δ
#linux 47.58% <ø> (ø) ⬆️
#windows 41.18% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/gc.go 61.51% <0%> (-4.71%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee916fe...f6ac73d. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 58dc067 into containerd:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants