Skip to content

Windows: Update stackdump event name#3024

Merged
estesp merged 1 commit intocontainerd:masterfrom
lowenna:jjh/signalname
Feb 18, 2019
Merged

Windows: Update stackdump event name#3024
estesp merged 1 commit intocontainerd:masterfrom
lowenna:jjh/signalname

Conversation

@lowenna
Copy link
Copy Markdown

@lowenna lowenna commented Feb 15, 2019

Signed-off-by: John Howard [email protected]

Doing a blanket update of the event name for consistency across docker, containerd, containerd-shim-runhcs-v1 and docker-signal to make life a lot easier and less typing.

@jterry75 PTAL

Associated PRs: moby/moby#38741, microsoft/hcsshim#480

@jterry75
Copy link
Copy Markdown
Contributor

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3024 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3024   +/-   ##
=======================================
  Coverage   43.96%   43.96%           
=======================================
  Files         102      102           
  Lines       10881    10881           
=======================================
  Hits         4784     4784           
  Misses       5362     5362           
  Partials      735      735
Flag Coverage Δ
#linux 47.58% <ø> (ø) ⬆️
#windows 41.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a378dbc...88f19a9. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 06ff5ef into containerd:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants