Skip to content

Add image handler wrapper#3010

Merged
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:pull-add-handler-wrap
Feb 18, 2019
Merged

Add image handler wrapper#3010
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:pull-add-handler-wrap

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Gives clients more control of the pull process, allowing
the client to operate on a descriptor after it has been
pulled. This could be useful for filtering output or
tracking children before they dispatched to. This can
also be used to call custom unpackers to have visibility
into a pulled config in parallel to the downloads.

@Random-Liu I move the pull logic like you did in #2918, hopefully
that makes rebasing easier.

Gives clients more control of the pull process, allowing
the client to operate on a descriptor after it has been
pulled. This could be useful for filtering output or
tracking children before they dispatched to. This can
also be used to call custom unpackers to have visibility
into a pulled config in parallel to the downloads.

Signed-off-by: Derek McGowan <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3010   +/-   ##
=======================================
  Coverage   43.96%   43.96%           
=======================================
  Files         102      102           
  Lines       10881    10881           
=======================================
  Hits         4784     4784           
  Misses       5362     5362           
  Partials      735      735
Flag Coverage Δ
#linux 47.58% <ø> (ø) ⬆️
#windows 41.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b0fa2...dc09ed1. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 480bf65 into containerd:master Feb 18, 2019
@dmcgowan dmcgowan deleted the pull-add-handler-wrap branch September 10, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants