Fix LCOW layer ordering#2993
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Feb 12, 2019
Merged
Conversation
Due to an error in the OCI specf for layerFolders, the runhcs shim was passing the layers for LCOW in reverse order. This fixes the ordering by simply removing the code which reversed the layers for LCOW. Signed-off-by: Kevin Parsons <[email protected]>
Member
Author
|
@jterry75 also fixed the OCI spec issue here: https://github.com/opencontainers/runtime-spec/pull/999/files |
Contributor
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2993 +/- ##
==========================================
- Coverage 47.58% 43.96% -3.62%
==========================================
Files 92 102 +10
Lines 8505 10881 +2376
==========================================
+ Hits 4047 4784 +737
- Misses 3731 5362 +1631
- Partials 727 735 +8
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an error in the OCI specf for layerFolders, the runhcs shim was
passing the layers for LCOW in reverse order. This fixes the ordering
by simply removing the code which reversed the layers for LCOW.
Signed-off-by: Kevin Parsons [email protected]