Skip to content

Vendor opencontainers/runtime-spec 29686dbc#2990

Merged
estesp merged 1 commit intocontainerd:masterfrom
lowenna:jjh/bumpruntimespec
Feb 11, 2019
Merged

Vendor opencontainers/runtime-spec 29686dbc#2990
estesp merged 1 commit intocontainerd:masterfrom
lowenna:jjh/bumpruntimespec

Conversation

@lowenna
Copy link
Copy Markdown

@lowenna lowenna commented Feb 7, 2019

Signed-off-by: John Howard [email protected]

Updates to the latest runtime-spec.

@lowenna
Copy link
Copy Markdown
Author

lowenna commented Feb 7, 2019

I've no idea where the 45-g bit came from. If someone can give me a clue, I can update.

@jterry75
Copy link
Copy Markdown
Contributor

jterry75 commented Feb 7, 2019

LGTM

@jterry75
Copy link
Copy Markdown
Contributor

jterry75 commented Feb 7, 2019

Can we just remove the comment? What is it good for?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2019

Codecov Report

Merging #2990 into master will decrease coverage by 3.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
- Coverage   47.58%   43.96%   -3.62%     
==========================================
  Files          92      102      +10     
  Lines        8505    10881    +2376     
==========================================
+ Hits         4047     4784     +737     
- Misses       3731     5362    +1631     
- Partials      727      735       +8
Flag Coverage Δ
#linux 47.58% <ø> (ø) ⬆️
#windows 41.18% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/gc.go 61.51% <0%> (-4.71%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4543e32...98766e8. Read the comment docs.

@estesp
Copy link
Copy Markdown
Member

estesp commented Feb 8, 2019

that's a reference of the form {tag}-{nn}-g{hash}, where {nn} is the number of commits past the {tag}, and {hash} is just a shorthash of the actual head commit. That form is generated with git describe --match {tag}

@lowenna
Copy link
Copy Markdown
Author

lowenna commented Feb 8, 2019

@estesp Thanks Phil! (@jterry75 now you know too 😂)

@lowenna lowenna force-pushed the jjh/bumpruntimespec branch from 9a94a9f to 98766e8 Compare February 8, 2019 02:48
@lowenna
Copy link
Copy Markdown
Author

lowenna commented Feb 8, 2019

Updated with the right comment in vendor.conf

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit b02ab6c into containerd:master Feb 11, 2019
@lowenna lowenna deleted the jjh/bumpruntimespec branch February 11, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants