Skip to content

Removes the oci.test.exe binary.#2989

Merged
estesp merged 1 commit intocontainerd:masterfrom
ehotinger:ehotinger/rmbin
Feb 7, 2019
Merged

Removes the oci.test.exe binary.#2989
estesp merged 1 commit intocontainerd:masterfrom
ehotinger:ehotinger/rmbin

Conversation

@ehotinger
Copy link
Copy Markdown
Contributor

Not sure why this was checked in from #2981.

Signed-off-by: Eric Hotinger [email protected]

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2989 into master will increase coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   41.18%   43.96%   +2.78%     
==========================================
  Files          71      102      +31     
  Lines        9531    10881    +1350     
==========================================
+ Hits         3925     4784     +859     
- Misses       5044     5362     +318     
- Partials      562      735     +173
Flag Coverage Δ
#linux 47.58% <ø> (?)
#windows 41.18% <ø> (ø) ⬆️
Impacted Files Coverage Δ
mount/temp_unix.go 0% <0%> (ø)
sys/reaper_linux.go 0% <0%> (ø)
services/server/server_linux.go 0% <0%> (ø)
sys/env.go 100% <0%> (ø)
sys/stat_unix.go 0% <0%> (ø)
runtime/v2/shim/shim_unix.go 0% <0%> (ø)
sys/reaper.go 0% <0%> (ø)
sys/fds.go 0% <0%> (ø)
runtime/v2/shim/reaper_unix.go 0% <0%> (ø)
sys/proc.go 0% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b89d42...0190e5f. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 0922c69 into containerd:master Feb 7, 2019
@ehotinger ehotinger deleted the ehotinger/rmbin branch February 7, 2019 20:48
@lowenna
Copy link
Copy Markdown

lowenna commented Feb 7, 2019

Thanks guys. Sorry about that. I should probably update .gitignore to include all .exe's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants