Skip to content

Add structure documentation for metadata#2982

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:metadata-structure-documentation
Feb 6, 2019
Merged

Add structure documentation for metadata#2982
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:metadata-structure-documentation

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Feb 5, 2019

Adds comment showing the structure of the buckets as stored in boltdb. Includes all bucket names, key names and descriptions of the stored values.

Note: It shows up better as raw

@dmcgowan dmcgowan force-pushed the metadata-structure-documentation branch from edca463 to daf309b Compare February 5, 2019 22:40
Adds comment showing the structure of the buckets
as stored in boltdb. Includes all bucket names, key names
and descriptions of the stored values.

Moves the metadata comment to package level to be exposed
in the godoc overview.

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the metadata-structure-documentation branch from daf309b to d25007e Compare February 5, 2019 22:45
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 5, 2019

Codecov Report

Merging #2982 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2982   +/-   ##
=======================================
  Coverage   43.98%   43.98%           
=======================================
  Files         102      102           
  Lines       10873    10873           
=======================================
  Hits         4782     4782           
  Misses       5358     5358           
  Partials      733      733
Flag Coverage Δ
#linux 47.63% <ø> (ø) ⬆️
#windows 41.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
metadata/buckets.go 56.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a410405...d25007e. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit b94b99d into containerd:master Feb 6, 2019
@dmcgowan dmcgowan deleted the metadata-structure-documentation branch September 10, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants