Add shim skeleton code#2979
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Feb 6, 2019
Merged
Conversation
crosbymichael
force-pushed
the
shim-skel
branch
from
6dddaab to
723e76c
Compare
ehazlett
reviewed
Feb 6, 2019
jterry75
reviewed
Feb 6, 2019
jterry75
reviewed
Feb 6, 2019
Contributor
|
This would of saved me some time 2 weeks ago 👍 ! |
This allows runtime authors to quickly bootstrap new shim implementations. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
shim-skel
branch
from
723e76c to
2dacef0
Compare
Member
Author
|
Comments addressed |
Codecov Report
@@ Coverage Diff @@
## master #2979 +/- ##
=======================================
Coverage 43.98% 43.98%
=======================================
Files 102 102
Lines 10873 10873
=======================================
Hits 4782 4782
Misses 5358 5358
Partials 733 733
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2979 +/- ##
=======================================
Coverage 43.98% 43.98%
=======================================
Files 102 102
Lines 10873 10873
=======================================
Hits 4782 4782
Misses 5358 5358
Partials 733 733
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows runtime authors to quickly bootstrap new shim
implementations.
Signed-off-by: Michael Crosby [email protected]