Skip to content

Fix potential containerd panic.#2976

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-potential-panic
Feb 5, 2019
Merged

Fix potential containerd panic.#2976
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-potential-panic

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

Fix a potential panic in containerd. This is needed in containerd/cri#1037.

Signed-off-by: Lantao Liu [email protected]

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 5, 2019

Codecov Report

Merging #2976 into master will decrease coverage by 3.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2976      +/-   ##
==========================================
- Coverage   47.63%   43.98%   -3.66%     
==========================================
  Files          92      102      +10     
  Lines        8514    10873    +2359     
==========================================
+ Hits         4056     4782     +726     
- Misses       3731     5358    +1627     
- Partials      727      733       +6
Flag Coverage Δ
#linux 47.63% <ø> (ø) ⬆️
#windows 41.19% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/gc.go 61.51% <0%> (-4.71%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca65dc9...7bd8dcd. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

cc @ehazlett for the 1.2.3 release

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 5ba3687 into containerd:master Feb 5, 2019
@Random-Liu Random-Liu deleted the fix-potential-panic branch February 5, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants