Skip to content

readme: fix example for checkpoint#2973

Merged
estesp merged 1 commit intocontainerd:masterfrom
Ace-Tang:fix_readme
Feb 4, 2019
Merged

readme: fix example for checkpoint#2973
estesp merged 1 commit intocontainerd:masterfrom
Ace-Tang:fix_readme

Conversation

@Ace-Tang
Copy link
Copy Markdown
Contributor

@Ace-Tang Ace-Tang commented Feb 2, 2019

fix example for checkpoint usage.

  1. change containerd.WithCheckpoint(checkpoint, "redis-rootfs") to containerd.WithNewSnapshot("redis-rootfs", checkpoint)
  2. containerd.WithTaskCheckpoint(checkpoint) , checkpint should be type Image

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2019

Codecov Report

Merging #2973 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2973   +/-   ##
=======================================
  Coverage   43.98%   43.98%           
=======================================
  Files         102      102           
  Lines       10873    10873           
=======================================
  Hits         4782     4782           
  Misses       5358     5358           
  Partials      733      733
Flag Coverage Δ
#linux 47.63% <ø> (ø) ⬆️
#windows 41.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b25c1e...f014adf. Read the comment docs.

@ehazlett
Copy link
Copy Markdown
Member

ehazlett commented Feb 4, 2019

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 7dc2c64 into containerd:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants