Skip to content

Fix deadlock in Windows runhcs shim exec#2971

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
jterry75:runhcs_shim_exec_deadlock
Feb 1, 2019
Merged

Fix deadlock in Windows runhcs shim exec#2971
crosbymichael merged 1 commit intocontainerd:masterfrom
jterry75:runhcs_shim_exec_deadlock

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

@jterry75 jterry75 commented Feb 1, 2019

Signed-off-by: Justin Terry (VM) [email protected]

@jterry75
Copy link
Copy Markdown
Contributor Author

jterry75 commented Feb 1, 2019

@jhowardmsft - You will need this for Docker integration.

Copy link
Copy Markdown

@lowenna lowenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread runtime/v2/runhcs/process.go Outdated
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 1, 2019

Codecov Report

Merging #2971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2971   +/-   ##
=======================================
  Coverage   43.98%   43.98%           
=======================================
  Files         102      102           
  Lines       10873    10873           
=======================================
  Hits         4782     4782           
  Misses       5358     5358           
  Partials      733      733
Flag Coverage Δ
#linux 47.63% <ø> (ø) ⬆️
#windows 41.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f24e2...dfcc594. Read the comment docs.

@jterry75 jterry75 force-pushed the runhcs_shim_exec_deadlock branch from eaa9c99 to dfcc594 Compare February 1, 2019 18:58
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 18a8a06 into containerd:master Feb 1, 2019
@jterry75 jterry75 deleted the runhcs_shim_exec_deadlock branch February 1, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants