[Release 1.2] Cherry-pick: metadata/gc: remove the noop-loop for snapshot reference#2965
Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from Jan 30, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.2 #2965 +/- ##
===============================================
+ Coverage 43.66% 43.66% +<.01%
===============================================
Files 101 101
Lines 10755 10754 -1
===============================================
Hits 4696 4696
+ Misses 5330 5329 -1
Partials 729 729
Continue to review full report at Codecov.
|
The noop-loop does nothing. The containerd doesn't have any snapshotter buckets at the beginning. If user uses specific dir as rootfs to create container, and sets `snapshotter` key to the container, like `overlayfs` by mistake, the gc scheduler will try to scan the snapshotter and panic. In order to avoid this case, remove the noop-loop here. Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 34672d4) Signed-off-by: Wei Fu <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The noop-loop does nothing.
The containerd doesn't have any snapshotter buckets at the beginning.
If user uses specific dir as rootfs to create container, and sets
snapshotterkey to the container, likeoverlayfsby mistake,the gc scheduler will try to scan the snapshotter and panic.
In order to avoid this case, remove the noop-loop here.
Signed-off-by: Wei Fu [email protected]
(cherry picked from commit 34672d4)
Signed-off-by: Wei Fu [email protected]