metadata/gc: remove the noop-loop for snapshot reference#2963
Merged
estesp merged 1 commit intocontainerd:masterfrom Jan 29, 2019
Merged
metadata/gc: remove the noop-loop for snapshot reference#2963estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
The noop-loop does nothing. The containerd doesn't have any snapshotter buckets at the beginning. If user uses specific dir as rootfs to create container, and sets `snapshotter` key to the container, like `overlayfs` by mistake, the gc scheduler will try to scan the snapshotter and panic. In order to avoid this case, remove the noop-loop here. Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2963 +/- ##
==========================================
- Coverage 47.62% 43.98% -3.65%
==========================================
Files 92 102 +10
Lines 8517 10873 +2356
==========================================
+ Hits 4056 4782 +726
- Misses 3734 5358 +1624
- Partials 727 733 +6
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
All buckets should definitely be nil checked before used. Since this condition can arrive based on specific data input and it is a noop, we should probably just back port to 1.1 and 1.2 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The noop-loop does nothing.
The containerd doesn't have any snapshotter buckets at the beginning.
If user uses specific dir as rootfs to create container, and sets
snapshotterkey to the container, likeoverlayfsby mistake,the gc scheduler will try to scan the snapshotter and panic.
In order to avoid this case, remove the noop-loop here.
Signed-off-by: Wei Fu [email protected]
for example,