Update snapshots docs with garbage collector label#2962
Merged
estesp merged 1 commit intocontainerd:masterfrom Jan 29, 2019
Merged
Update snapshots docs with garbage collector label#2962estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
==========================================
- Coverage 47.62% 43.97% -3.65%
==========================================
Files 92 102 +10
Lines 8517 10874 +2357
==========================================
+ Hits 4056 4782 +726
- Misses 3734 5359 +1625
- Partials 727 733 +6
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
==========================================
- Coverage 47.62% 43.97% -3.65%
==========================================
Files 92 102 +10
Lines 8517 10874 +2357
==========================================
+ Hits 4056 4782 +726
- Misses 3734 5359 +1625
- Partials 727 733 +6
Continue to review full report at Codecov.
|
ehazlett
reviewed
Jan 29, 2019
ostenbom
force-pushed
the
snapshots-docs
branch
from
682fb99 to
d45beab
Compare
Signed-off-by: Oliver Stenbom <[email protected]>
ostenbom
force-pushed
the
snapshots-docs
branch
from
d45beab to
7f5d7ff
Compare
Member
|
LGTM |
Member
|
merging per comment re: Windows CI flakiness; this is only edits to comments/documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2941. When following the normal snapshots tutorial, any delay or unpacking large layers lets the garbage collector delete the snapshot in use. Add a no garbage collector label to the docs to make that clear.
Also, calling
Commitshould remove the active snapshot so no need to do that in the tutorial.Signed-off-by: Oliver Stenbom [email protected]