Fix bug in shim path lookup#2961
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jan 30, 2019
Merged
Conversation
Signed-off-by: Justin Terry (VM) <[email protected]>
Contributor
Author
|
@crosbymichael, @ehazlett - Well that was embarrassing. #2960 had a copy paste bug that compiled by accident and updated the wrong path. Here is the correct fix. |
Contributor
Author
|
@crosbymichael - What is the build failure here? Its unclear from the logs |
Member
|
it seems that client failed to connect containerd. |
Member
|
It looks like windows CI is having some issues and is not being stable |
Codecov Report
@@ Coverage Diff @@
## master #2961 +/- ##
==========================================
- Coverage 47.62% 44.33% -3.29%
==========================================
Files 92 102 +10
Lines 8517 10907 +2390
==========================================
+ Hits 4056 4836 +780
- Misses 3734 5339 +1605
- Partials 727 732 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Terry (VM) [email protected]