remove excessive []byte(s) conversion#2959
Merged
estesp merged 1 commit intocontainerd:masterfrom Jan 28, 2019
quasilyte:patch-1
Merged
remove excessive []byte(s) conversion#2959estesp merged 1 commit intocontainerd:masterfrom quasilyte:patch-1
estesp merged 1 commit intocontainerd:masterfrom
quasilyte:patch-1
Conversation
`copy` permits using to mix `[]byte` and `string` arguments without explicit conversion. I removed explicit conversion to make the code simpler. Signed-off-by: Iskander Sharipov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2959 +/- ##
=======================================
Coverage 44.02% 44.02%
=======================================
Files 102 102
Lines 10863 10863
=======================================
Hits 4782 4782
Misses 5348 5348
Partials 733 733
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copypermits using to mix[]byteandstringarguments withoutexplicit conversion. I removed explicit conversion to make the code simpler.
Signed-off-by: Iskander Sharipov [email protected]