Skip to content

Move task events to runc v2 shim#2958

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:runcv2-events
Jan 25, 2019
Merged

Move task events to runc v2 shim#2958
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:runcv2-events

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

Comment thread runtime/v2/runc/service.go Outdated
Comment thread runtime/v2/runc/service.go Outdated
Comment thread runtime/v2/runc/service.go Outdated
Signed-off-by: Michael Crosby <[email protected]>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 25, 2019

Codecov Report

Merging #2958 into master will decrease coverage by 3.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2958      +/-   ##
==========================================
- Coverage   47.64%   44.02%   -3.63%     
==========================================
  Files          92      102      +10     
  Lines        8513    10863    +2350     
==========================================
+ Hits         4056     4782     +726     
- Misses       3730     5348    +1618     
- Partials      727      733       +6
Flag Coverage Δ
#linux 47.64% <ø> (ø) ⬆️
#windows 41.23% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aac018...85aa8ad. Read the comment docs.

Copy link
Copy Markdown
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 9f705f4 into containerd:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants