[release/1.2] cherrypick: Use context.Background for O_NONBLOCK OpenFifo.#2955
Merged
dmcgowan merged 1 commit intocontainerd:release/1.2from Jan 24, 2019
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.2 #2955 +/- ##
==============================================
- Coverage 47.48% 43.8% -3.68%
==============================================
Files 91 100 +9
Lines 8407 10720 +2313
==============================================
+ Hits 3992 4696 +704
- Misses 3692 5295 +1603
- Partials 723 729 +6
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of #2944 .
In release 1.2, we don't have new ttrpc, so we don't have the
OpenFifostopped by context cancellation issue. However, we still have the un-cancelled 30s timeout context issue mentioned in #2944 (comment).Signed-off-by: Lantao Liu [email protected]