[release/1.1] fix: linter issue#2951
Merged
estesp merged 1 commit intocontainerd:release/1.1from Jan 23, 2019
Merged
Conversation
megacheck, gosimple and unused has been deprecated and subsumed by staticcheck. And staticcheck also has been upgraded. we need to update code for the linter issue. close: containerd#2945 Signed-off-by: Wei Fu <[email protected]> Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
lint-relase11
branch
from
bfae8a6 to
ff8a80e
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.1 #2951 +/- ##
===============================================
- Coverage 48.99% 48.98% -0.02%
===============================================
Files 85 85
Lines 7603 7601 -2
===============================================
- Hits 3725 3723 -2
Misses 3203 3203
Partials 675 675
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
megacheck, gosimple and unused has been deprecated and subsumed by
staticcheck. And staticcheck also has been upgraded. we need to update
code for the linter issue.
close: #2945
Signed-off-by: Wei Fu [email protected]