fix: linter issue#2948
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jan 23, 2019
Merged
Conversation
fuweid
force-pushed
the
fix_linter_issue
branch
from
229d872 to
5e94e30
Compare
megacheck, gosimple and unused has been deprecated and subsumed by staticcheck. And staticcheck also has been upgraded. we need to update code for the linter issue. close: containerd#2945 Signed-off-by: Wei Fu <[email protected]>
fuweid
force-pushed
the
fix_linter_issue
branch
from
5e94e30 to
132ee9b
Compare
fuweid
commented
Jan 23, 2019
| for s := range signals { | ||
| switch s { | ||
| case os.Interrupt: | ||
| break |
Member
Author
There was a problem hiding this comment.
the original one doesn't break out of an outer loop so that I remove the break statement here
Codecov Report
@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 44.02% 44.02% +<.01%
==========================================
Files 102 102
Lines 10870 10862 -8
==========================================
- Hits 4785 4782 -3
+ Misses 5351 5347 -4
+ Partials 734 733 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 44.02% 44.02% +<.01%
==========================================
Files 102 102
Lines 10870 10862 -8
==========================================
- Hits 4785 4782 -3
+ Misses 5351 5347 -4
+ Partials 734 733 -1
Continue to review full report at Codecov.
|
estesp
approved these changes
Jan 23, 2019
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM - all these changes look reasonable to me
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
megacheck, gosimple and unused has been deprecated and subsumed by
staticcheck. And staticcheck also has been upgraded. we need to update
code for the linter issue.
close: #2945
Signed-off-by: Wei Fu [email protected]