Update ttrpc to support context timeout.#2930
Merged
estesp merged 1 commit intocontainerd:masterfrom Jan 15, 2019
Merged
Conversation
Signed-off-by: Brian Goff <[email protected]>
Member
travis-ci testing case fails because the docker registry is unstable I guess :P |
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
=======================================
Coverage 44.02% 44.02%
=======================================
Files 102 102
Lines 10871 10871
=======================================
Hits 4786 4786
Misses 5351 5351
Partials 734 734
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
=======================================
Coverage 44.02% 44.02%
=======================================
Files 102 102
Lines 10871 10871
=======================================
Hits 4786 4786
Misses 5351 5351
Partials 734 734
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a bit of a loss on how to write a test case for this.
Existing ttrpc libs will already honor a canceled context if it's canceled before dispatch in the ttrpc client is called.
Other methods on the containerd client go through grpc which is already going to return early on a cancelled context.
Thought of writing a custom shim implementation but then that's not really testing much, certainly not anything more than what's being tested in the ttrpc repo already.
Thoughts?