Skip to content

Add Golang 1.12.5#2896

Merged
crosbymichael merged 2 commits intocontainerd:masterfrom
thaJeztah:bump_golang_1.12
May 15, 2019
Merged

Add Golang 1.12.5#2896
crosbymichael merged 2 commits intocontainerd:masterfrom
thaJeztah:bump_golang_1.12

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Dec 20, 2018

Hopefully CI here will have a better color than in moby/moby#38404

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 20, 2018 •
edited
Loading

Codecov Report

Merging #2896 into master will decrease coverage by 3.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2896      +/-   ##
=========================================
- Coverage   48.33%   44.4%   -3.93%     
=========================================
  Files         102     113      +11     
  Lines        9627   12231    +2604     
=========================================
+ Hits         4653    5431     +778     
- Misses       4149    5966    +1817     
- Partials      825     834       +9
Flag Coverage Δ
#linux 48.33% <ø> (ø) ⬆️
#windows 39.66% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 49.51% <0%> (-5.15%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc94455...543d1e8. Read the comment docs.

@estesp
Copy link
Copy Markdown
Member

estesp commented Dec 20, 2018

All 💚

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Dec 20, 2018

Whoop!

Dang, but we'll still have to solve the issues in moby/moy 😞 😂

@thaJeztah thaJeztah changed the title [WIP] Add Golang 1.12beta1 [WIP] Add Golang 1.12beta2 Jan 12, 2019
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 12, 2019

@estesp looks like containerd is segfaulting on PowerPC; from the moby PR: moby/moby#38404 (comment) Perhaps you're able to verify it on a PowerPC machine?

❌ PowerPC SEGFAULTS on containerd https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/12976/console

I see there's codechanges in Go three months ago; golang/go@05166bf (and golang/go@020a18c)

Details 
time="2019-01-12T13:03:20.804794817Z" level=debug msg="Listener created for HTTP on unix (/go/src/github.com/docker/docker/bundles/test-integration/docker.sock)"
time="2019-01-12T13:03:20.808714648Z" level=info msg="libcontainerd: started new containerd process" pid=11308
time="2019-01-12T13:03:20.808850226Z" level=info msg="parsed scheme: \"unix\"" module=grpc
time="2019-01-12T13:03:20.808900947Z" level=info msg="scheme \"unix\" not registered, fallback to default scheme" module=grpc
time="2019-01-12T13:03:20.809671693Z" level=info msg="ccResolverWrapper: sending new addresses to cc: [{unix:///var/run/docker/containerd/containerd.sock 0  <nil>}]" module=grpc
time="2019-01-12T13:03:20.809720306Z" level=info msg="ClientConn switching balancer to \"pick_first\"" module=grpc
time="2019-01-12T13:03:20.809834204Z" level=info msg="pickfirstBalancer: HandleSubConnStateChange: 0xc000153d70, CONNECTING" module=grpc
time="2019-01-12T13:03:20.890647567Z" level=info msg="starting containerd" revision=9754871865f7fe2f4e74d43e2fc7ccd237edcbce version=v1.2.2 
time="2019-01-12T13:03:20.890846262Z" level=debug msg="changing OOM score to -500" 
time="2019-01-12T13:03:20.891556648Z" level=info msg="loading plugin "io.containerd.content.v1.content"..." type=io.containerd.content.v1 
time="2019-01-12T13:03:20.891759951Z" level=info msg="loading plugin "io.containerd.snapshotter.v1.btrfs"..." type=io.containerd.snapshotter.v1 
time="2019-01-12T13:03:20.892072555Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.btrfs" error="path /var/lib/docker/containerd/daemon/io.containerd.snapshotter.v1.btrfs must be a btrfs filesystem to be used with the btrfs snapshotter" 
time="2019-01-12T13:03:20.892096816Z" level=info msg="loading plugin "io.containerd.snapshotter.v1.aufs"..." type=io.containerd.snapshotter.v1 
time="2019-01-12T13:03:20.892476929Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.aufs" error="modprobe aufs failed: "": exec: "modprobe": executable file not found in $PATH" 
time="2019-01-12T13:03:20.892505544Z" level=info msg="loading plugin "io.containerd.snapshotter.v1.native"..." type=io.containerd.snapshotter.v1 
time="2019-01-12T13:03:20.892642251Z" level=info msg="loading plugin "io.containerd.snapshotter.v1.overlayfs"..." type=io.containerd.snapshotter.v1 
time="2019-01-12T13:03:20.892885741Z" level=info msg="loading plugin "io.containerd.snapshotter.v1.zfs"..." type=io.containerd.snapshotter.v1 
time="2019-01-12T13:03:20.893414575Z" level=warning msg="failed to load plugin io.containerd.snapshotter.v1.zfs" error="path /var/lib/docker/containerd/daemon/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter" 
time="2019-01-12T13:03:20.893437564Z" level=info msg="loading plugin "io.containerd.metadata.v1.bolt"..." type=io.containerd.metadata.v1 
time="2019-01-12T13:03:20.893514513Z" level=warning msg="could not use snapshotter zfs in metadata plugin" error="path /var/lib/docker/containerd/daemon/io.containerd.snapshotter.v1.zfs must be a zfs filesystem to be used with the zfs snapshotter" 
time="2019-01-12T13:03:20.893530342Z" level=warning msg="could not use snapshotter btrfs in metadata plugin" error="path /var/lib/docker/containerd/daemon/io.containerd.snapshotter.v1.btrfs must be a btrfs filesystem to be used with the btrfs snapshotter" 
time="2019-01-12T13:03:20.893546919Z" level=warning msg="could not use snapshotter aufs in metadata plugin" error="modprobe aufs failed: "": exec: "modprobe": executable file not found in $PATH" 
unexpected fault address 0xbfff53a940
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x1 addr=0xbfff53a940 pc=0x1004beb0]

goroutine 1 [running]:
runtime.throw(0x10db6f9b, 0x5)
	/usr/local/go/src/runtime/panic.go:617 +0x68 fp=0xc0004de6b8 sp=0xc0004de678 pc=0x100318b8
runtime.sigpanic()
	/usr/local/go/src/runtime/signal_unix.go:397 +0x464 fp=0xc0004de6f8 sp=0xc0004de6b8 pc=0x1004ab34
runtime.makeslice(0xbfff53a940, 0x38, 0x38, 0x7)
	/usr/local/go/src/runtime/slice.go:35 +0x40 fp=0xc0004de758 sp=0xc0004de718 pc=0x1004beb0
github.com/containerd/containerd/vendor/go.etcd.io/bbolt.(*Bucket).write(0xc0002eb600, 0xc000238201, 0xc0004de958, 0x1136a6a0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/go.etcd.io/bbolt/bucket.go:617 +0x6c fp=0xc0004de7b0 sp=0xc0004de758 pc=0x10291fac
github.com/containerd/containerd/vendor/go.etcd.io/bbolt.(*Bucket).spill(0xc00023c018, 0x411f957, 0x120923c0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/go.etcd.io/bbolt/bucket.go:533 +0xe4 fp=0xc0004de9b8 sp=0xc0004de7b0 pc=0x10291824
github.com/containerd/containerd/vendor/go.etcd.io/bbolt.(*Tx).Commit(0xc00023c000, 0x0, 0x0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/go.etcd.io/bbolt/tx.go:160 +0xd0 fp=0xc0004deaf8 sp=0xc0004de9b8 pc=0x1029ee60
github.com/containerd/containerd/vendor/go.etcd.io/bbolt.(*DB).Update(0xc0004b81e0, 0xc0004debb8, 0x0, 0x0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/go.etcd.io/bbolt/db.go:677 +0x108 fp=0xc0004deb58 sp=0xc0004deaf8 pc=0x10296b78
github.com/containerd/containerd/metadata.(*DB).Init(0xc00026aa20, 0x11581820, 0xc0000b4010, 0xc0004ded30, 0xc00026aa20)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/metadata/db.go:103 +0xec fp=0xc0004debe0 sp=0xc0004deb58 pc=0x102b03ec
github.com/containerd/containerd/services/server.LoadPlugins.func2(0xc000307570, 0xc0001be060, 0x21, 0xc0001e9740, 0x1e)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/services/server/server.go:269 +0x580 fp=0xc0004defe0 sp=0xc0004debe0 pc=0x10d09c60
github.com/containerd/containerd/plugin.(*Registration).Init(0xc0002d2e10, 0xc000307570, 0xc0002d2e10)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/plugin/plugin.go:100 +0x50 fp=0xc0004df048 sp=0xc0004defe0 pc=0x10521a70
github.com/containerd/containerd/services/server.New(0x11581820, 0xc0000b4010, 0xc00036de60, 0x1, 0xc0004dfa28, 0x0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/services/server/server.go:120 +0x5d4 fp=0xc0004df608 sp=0xc0004df048 pc=0x10d06cf4
github.com/containerd/containerd/cmd/containerd/command.App.func1(0xc0001bc000, 0xc0001bc000, 0xc0004dfbc8)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/cmd/containerd/command/main.go:141 +0x724 fp=0xc0004dfbb0 sp=0xc0004df608 pc=0x10d21364
github.com/containerd/containerd/vendor/github.com/urfave/cli.HandleAction(0x1133ece0, 0x1152af08, 0xc0001bc000, 0xc00026a1e0, 0x0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/github.com/urfave/cli/app.go:502 +0xfc fp=0xc0004dfbe8 sp=0xc0004dfbb0 pc=0x10d0d41c
github.com/containerd/containerd/vendor/github.com/urfave/cli.(*App).Run(0xc000330000, 0xc0000be000, 0x5, 0x5, 0x0, 0x0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/github.com/urfave/cli/app.go:268 +0x480 fp=0xc0004dfee8 sp=0xc0004dfbe8 pc=0x10d0b570
main.main()
	github.com/containerd/containerd/cmd/containerd/main.go:33 +0x5c fp=0xc0004dff68 sp=0xc0004dfee8 pc=0x10d2304c
runtime.main()
	/usr/local/go/src/runtime/proc.go:200 +0x278 fp=0xc0004dffc0 sp=0xc0004dff68 pc=0x10033478
runtime.goexit()
	/usr/local/go/src/runtime/asm_ppc64x.s:856 +0x4 fp=0xc0004dffc0 sp=0xc0004dffc0 pc=0x10065734

goroutine 19 [syscall]:
os/signal.signal_recv(0x0)
	/usr/local/go/src/runtime/sigqueue.go:139 +0x10c
os/signal.loop()
	/usr/local/go/src/os/signal/signal_unix.go:23 +0x38
created by os/signal.init.0
	/usr/local/go/src/os/signal/signal_unix.go:29 +0x50

goroutine 20 [chan receive]:
github.com/containerd/containerd/vendor/github.com/golang/glog.(*loggingT).flushDaemon(0x120927c0)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/github.com/golang/glog/glog.go:879 +0x8c
created by github.com/containerd/containerd/vendor/github.com/golang/glog.init.0
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/github.com/golang/glog/glog.go:410 +0x2f8

goroutine 8 [select]:
github.com/containerd/containerd/cmd/containerd/command.handleSignals.func1(0xc00026a2a0, 0xc00026a240, 0x11581820, 0xc0000b4010, 0xc000326120)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/cmd/containerd/command/main_unix.go:46 +0xd0
created by github.com/containerd/containerd/cmd/containerd/command.handleSignals
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/cmd/containerd/command/main_unix.go:43 +0x90

goroutine 10 [select]:
github.com/containerd/containerd/vendor/github.com/docker/go-events.(*Broadcaster).run(0xc0002d2e60)
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/github.com/docker/go-events/broadcast.go:117 +0x140
created by github.com/containerd/containerd/vendor/github.com/docker/go-events.NewBroadcaster
	/tmp/tmp.4xYdjUI6lQ/src/github.com/containerd/containerd/vendor/github.com/docker/go-events/broadcast.go:39 +0x1e8
time="2019-01-12T13:03:20.900109015Z" level=error msg="containerd did not exit successfully" error="exit status 2" module=libcontainerd
failed to start containerd: timeout waiting for containerd to start

@thaJeztah thaJeztah mentioned this pull request Jan 12, 2019
Closed
@thaJeztah thaJeztah force-pushed the bump_golang_1.12 branch 2 times, most recently from 0213a39 to def0ecf Compare January 13, 2019 00:42
@estesp
Copy link
Copy Markdown
Member

estesp commented Jan 14, 2019

I've let all my access to PowerPC systems expire, so would have to re-acquire a VM somewhere. @clnperez do you have the ability to check this out?

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 14, 2019

Let me change this PR back to just the bump; was messing with some options to see if I could get it to try ppc64

@thaJeztah thaJeztah mentioned this pull request Feb 12, 2019
Closed
@thaJeztah thaJeztah mentioned this pull request Feb 15, 2019
Merged
@thaJeztah thaJeztah force-pushed the bump_golang_1.12 branch 2 times, most recently from 5129942 to a17862d Compare February 18, 2019 12:48
@thaJeztah thaJeztah changed the title [WIP] Add Golang 1.12beta2 [WIP] Add Golang 1.12rc1 Feb 18, 2019
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 18, 2019

Updated to 1.12rc1

@estesp
Copy link
Copy Markdown
Member

estesp commented Feb 26, 2019

Go 1.12 is out; not sure how quickly Travis has the builds available. Also, might be interesting to add linux-ppc64le to the OS list, as apparently I found out earlier today that Travis officially added ppc64le architecture support.

@thaJeztah thaJeztah force-pushed the bump_golang_1.12 branch 9 times, most recently from f378b3b to de45db5 Compare February 26, 2019 23:37
@thaJeztah thaJeztah changed the title [WIP] Add Golang 1.12rc1 [WIP] Add Golang 1.12.0 Feb 26, 2019
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Feb 27, 2019

Looks like the powerpc builds took longer than 50 minutes and were terminated

@thaJeztah thaJeztah changed the title [WIP] Add Golang 1.12.0 Add Golang 1.12.0 Mar 13, 2019
@thaJeztah thaJeztah mentioned this pull request Mar 13, 2019
Merged
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Mar 22, 2019

What's current status?

@jterry75
Copy link
Copy Markdown
Contributor

jterry75 commented Mar 26, 2019

@jhowardmsft - What is the issue for v1.12 on Windows? I thought we required v1.12.1?

@lowenna
Copy link
Copy Markdown

lowenna commented Mar 26, 2019

@jterry75 we do need 1.12.1. I was waiting for Seb to catch up after PTO before hassling him 😇. Too late, I just did, @thaJeztah

@lowenna
Copy link
Copy Markdown

lowenna commented Mar 26, 2019

BTW I’m happy to carry this if you don’t have time. LMK if you need help. The rest of the Windows stack is bumped and working. Just containerd remains.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 26, 2019

Hm; I see some timeouts during vendoring (seen that on other repositories as well, might be GitHub being slow)

$ ../project/script/validate/vendor
2019/03/16 17:05:24 Collecting initial packages
2019/03/16 17:05:24 Download dependencies
2019/03/16 17:05:24 Starting whole vndr cycle because no package specified
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 26, 2019

Note that we may want to wait for Go 1.12.2 to arrive; see golang/go#30977

@dmcgowan dmcgowan added this to the 1.3-beta.0 milestone Apr 4, 2019
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 6, 2019

1.12.2 is available now

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented May 8, 2019

What's current status?

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 8, 2019

I can rebase and update this one, but the problem was making the s390x/power CI pass; it was too slow, so kept timing out

@thaJeztah thaJeztah force-pushed the bump_golang_1.12 branch from 4b52614 to b1c9909 Compare May 8, 2019 17:18
@thaJeztah thaJeztah changed the title Add Golang 1.12.0 Add Golang 1.12.5 May 8, 2019
@estesp
Copy link
Copy Markdown
Member

estesp commented May 10, 2019 •
edited
Loading

@thaJeztah I suggest making this PR just for the Golang move--as seen in #3272 there are probably deeper issues with trying to get Travis's new architecture support in good enough shape to rely on for regular CI.

Edit: Although you clearly figured out skipping the useless darwin / ppc64le combo using the matrix include entry.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 10, 2019

Let me update and disable powerpc. Some gofmt issues as well it seems, and these are weird;

task_opts.go:1::warning: file is not goimported (goimports)
windows/io.go:1::warning: file is not goimported (goimports)
archive/tar.go:34:2:warning: unused struct field could not import github.com/containerd/continuity/fs (cannot find package "github.com/containerd/continuity/fs" in any of: (structcheck)
archive/tar.go:35:2:warning: unused struct field could not import github.com/pkg/errors (cannot find package "github.com/pkg/errors" in any of: (structcheck)

log.txt

thaJeztah added 2 commits May 10, 2019 14:07
@thaJeztah
Update to Golang 1.12, and prepare for ppc64le
00bc2f5 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Add travis_wait to prevent vndr timing out
543d1e8 
Pervent travis from timing out because no output was printed;

    No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented May 15, 2019

@estesp @AkihiroSuda this ok to merge? Or do you want all the ppc related changes to be removed?

estesp
estesp approved these changes May 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm good with keeping the prep work for a future enablement of ppc64le.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented May 15, 2019

LGTM

@crosbymichael crosbymichael merged commit cd5369b into containerd:master May 15, 2019
@jterry75
Copy link
Copy Markdown
Contributor

jterry75 commented May 15, 2019

Nice!

@thaJeztah thaJeztah deleted the bump_golang_1.12 branch May 17, 2019 14:27
@thaJeztah thaJeztah mentioned this pull request Jun 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3-beta.0

Development

Successfully merging this pull request may close these issues.

8 participants

@thaJeztah @codecov-io @estesp @AkihiroSuda @jterry75 @lowenna @crosbymichael @dmcgowan