Skip to content

[release/1.1] Revert "Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)"#2892

Merged
estesp merged 1 commit intocontainerd:release/1.1from
thaJeztah:1.1_revert_temp_golang_fix
Dec 19, 2018
Merged

[release/1.1] Revert "Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround)"#2892
estesp merged 1 commit intocontainerd:release/1.1from
thaJeztah:1.1_revert_temp_golang_fix

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

This reverts commit 66a3eeb (#2880)

Golang 1.10.7 and 1.11.4 have been released, which address the regression, so we no longer need this temporary workaround

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2892 into release/1.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.1    #2892   +/-   ##
============================================
  Coverage        48.99%   48.99%           
============================================
  Files               85       85           
  Lines             7603     7603           
============================================
  Hits              3725     3725           
  Misses            3203     3203           
  Partials           675      675
Flag Coverage Δ
#linux 48.99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e398d...0e93a1e. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit b55cf2c into containerd:release/1.1 Dec 19, 2018
@thaJeztah thaJeztah deleted the 1.1_revert_temp_golang_fix branch December 19, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants