fix: SCHILY.xattrs should be SCHILY.xattr#2873
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Dec 13, 2018
Merged
Conversation
Member
|
fixes: #2863 |
Contributor
Author
Member
Contributor
Author
|
The golang source code is important to debug 😸 |
AkihiroSuda
approved these changes
Dec 12, 2018
Member
Maybe we can just detect this case and skip, is there another case to run in its place for CI or does the first test adequately test what you wanted? |
from golang code https://github.com/golang/go/blob/bad6b6fa9190e9079a6d6958859856a66f0fab87/src/archive/tar/common.go#L110 add unit test for tar xattr Fixes: containerd#2863 Signed-off-by: Ace-Tang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
==========================================
+ Coverage 41.04% 43.87% +2.82%
==========================================
Files 70 101 +31
Lines 9445 10796 +1351
==========================================
+ Hits 3877 4737 +860
- Misses 5010 5328 +318
- Partials 558 731 +173
Continue to review full report at Codecov.
|
Contributor
Author
|
@dmcgowan, Security related xattrs need root permission to test, I have updated. |
Member
|
LGTM |
This was referenced Jan 23, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from golang code
https://github.com/golang/go/blob/bad6b6fa9190e9079a6d6958859856a66f0fab87/src/archive/tar/common.go#L110
Signed-off-by: Ace-Tang [email protected]