Add /proc/asound to masked paths#2846
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Nov 30, 2018
Merged
Conversation
While looking through the Moby source code was found /proc/asound to be shared with containers as read-only. This can lead to two information leaks. --- **Leak of media playback status of the host** Steps to reproduce the issue: - Listen to music/Play a YouTube video/Do anything else that involves sound output - Execute docker run --rm ubuntu:latest bash -c "sleep 7; cat /proc/asound/card*/pcm*p/sub*/status | grep state | cut -d ' ' -f2 | grep RUNNING || echo 'not running'" - See that the containerized process is able to check whether someone on the host is playing music as it prints RUNNING - Stop the music output - Execute the command again (The sleep is delaying the output because information regarding playback status isn't propagated instantly) - See that it outputs not running **Describe the results you received:** A containerized process is able to gather information on the playback status of an audio device governed by the host. Therefore a process of a container is able to check whether and what kind of user activity is present on the host system. Also, this may indicate whether a container runs on a desktop system or a server as media playback rarely happens on server systems. The description above is in regard to media playback - when examining `/proc/asound/card*/pcm*c/sub*/status` (`pcm*c` instead of `pcm*p`) this can also leak information regarding capturing sound, as in recording audio or making calls on the host system. Reported-by: Philipp Schmied <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
This was referenced Nov 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #2846 +/- ##
=======================================
Coverage 43.76% 43.76%
=======================================
Files 100 100
Lines 10749 10749
=======================================
Hits 4704 4704
Misses 5315 5315
Partials 730 730
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Nov 30, 2018
Member
|
LGTM |
|
Is there no better solution? now only privileged add-ons can play music :( |
Member
|
@pvizeli this is only the default spec that is generated. As a user, you can configure the spec however you see fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports moby/moby#38299 to containerd
relates to moby/moby#38285
While looking through the Moby source code was found /proc/asound to be shared
with containers as read-only.
This can lead to two information leaks.
Leak of media playback status of the host
Steps to reproduce the issue:
output
/proc/asound/card*/pcmp/sub/status | grep state | cut -d ' ' -f2 | grep
RUNNING || echo 'not running'"
host is playing music as it prints RUNNING
information regarding playback status isn't propagated instantly)
Describe the results you received:
A containerized process is able to gather information on the playback
status of an audio device governed by the host. Therefore a process of a
container is able to check whether and what kind of user activity is
present on the host system. Also, this may indicate whether a container
runs on a desktop system or a server as media playback rarely happens on
server systems.
The description above is in regard to media playback - when examining
/proc/asound/card*/pcm*c/sub*/status(pcm*cinstead ofpcm*p) thiscan also leak information regarding capturing sound, as in recording
audio or making calls on the host system.
Reported-by: Philipp Schmied [email protected]
Signed-off-by: Sebastiaan van Stijn [email protected]