Skip to content

Move ctr run --isolation to Windows only#2828

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
jterry75:ctr_isolation
Nov 28, 2018
Merged

Move ctr run --isolation to Windows only#2828
dmcgowan merged 1 commit intocontainerd:masterfrom
jterry75:ctr_isolation

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

Signed-off-by: Justin Terry (VM) [email protected]

Resolves: #2827

@Ace-Tang
Copy link
Copy Markdown
Contributor

@jterry75 , maybe need to restart ci to make ci happy, my pr also fails in that time interval

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2828 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   43.79%   43.79%           
=======================================
  Files         100      100           
  Lines       10741    10741           
=======================================
  Hits         4704     4704           
  Misses       5307     5307           
  Partials      730      730
Flag Coverage Δ
#linux 47.45% <ø> (ø) ⬆️
#windows 40.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c490c...f90e5d5. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@dmcgowan
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows run with isolation option shown for run command on linux

6 participants