[release/1.0] Fix options ordering in proto api txt files#2780
Merged
estesp merged 1 commit intocontainerd:release/1.0from Nov 10, 2018
Merged
[release/1.0] Fix options ordering in proto api txt files#2780estesp merged 1 commit intocontainerd:release/1.0from
estesp merged 1 commit intocontainerd:release/1.0from
Conversation
An upstream change caused the options to now be ordered Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit d3cd5f1) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @dmcgowan @AkihiroSuda ptal |
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2780 +/- ##
============================================
Coverage 50.95% 50.95%
============================================
Files 81 81
Lines 7205 7205
============================================
Hits 3671 3671
Misses 2833 2833
Partials 701 701
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Nov 10, 2018
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2470 for the release/1.0 branch;
cherry-pick was clean; no conflicts
An upstream change caused the options to now be ordered