[release/1.2] cherry-pick: Ignore modprobe failures in ExecStartPre (systemd unit)#2779
Conversation
When running containerd inside LXC, due to systemd being unable to execute `modprobe overlay` inside the container (module is already loaded in host kernel). This patch adds a `-` prefix to the `ExecStartPre` command, so that failures are ignored, and the service can start as usual. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 555ea3f) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
=======================================
Coverage 43.72% 43.72%
=======================================
Files 100 100
Lines 10734 10734
=======================================
Hits 4693 4693
Misses 5311 5311
Partials 730 730
Continue to review full report at Codecov.
|
|
Is this just a GitHub UI problem that it isn’t listing the target as |
|
Hm interesting. Could also be a slip-up on my side (looking from my phone right now) OTOH, if this was targeting master, it would usually show as "merged" on github (once the other PR got merged) Let me try editing the PR's target (good catch btw, thanks!) |
|
Changed to release/1.2 Let's blame erm... the weather... politics... solar flares... (pick one) 😅🤗 |
4 participants
Backport of #2776 for the 1.2 branch
fixes #2772 for the 1.2.x releases
cherry-pick was clean; no conflicts
When running containerd inside LXC, due to systemd being unable to execute
modprobe overlayinside the container (module is already loaded in host kernel).This patch adds a
-prefix to theExecStartPrecommand, so that failuresare ignored, and the service can start as usual.