Ignore modprobe failures in ExecStartPre (systemd unit)#2776
Merged
estesp merged 1 commit intocontainerd:masterfrom Nov 10, 2018
Merged
Ignore modprobe failures in ExecStartPre (systemd unit)#2776estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
When running containerd inside LXC, due to systemd being unable to execute `modprobe overlay` inside the container (module is already loaded in host kernel). This patch adds a `-` prefix to the `ExecStartPre` command, so that failures are ignored, and the service can start as usual. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@lbschenkel @estesp @crosbymichael Also opened backports for active releases;
|
This was referenced Nov 10, 2018
|
+1. Looks good to me, but I'm just a bystander. |
Codecov Report
@@ Coverage Diff @@
## master #2776 +/- ##
=======================================
Coverage 43.72% 43.72%
=======================================
Files 100 100
Lines 10734 10734
=======================================
Hits 4693 4693
Misses 5311 5311
Partials 730 730
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Nov 10, 2018
This was referenced Nov 12, 2018
This was referenced Nov 20, 2018
hswong3i
added a commit
to alvistack/ansible-role-docker
that referenced
this pull request
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running containerd inside LXC, due to systemd being unable to execute
modprobe overlayinside the container (module is already loaded in host kernel).This patch adds a
-prefix to theExecStartPrecommand, so that failuresare ignored, and the service can start as usual.
fixes #2772