Skip to content

[release/1.1] cherry-pick: enhance: update v1/v2 runtime#2774

Merged
crosbymichael merged 1 commit intocontainerd:release/1.1from
Random-Liu:cherrypick-#2769-release-1.1
Nov 12, 2018
Merged

[release/1.1] cherry-pick: enhance: update v1/v2 runtime#2774
crosbymichael merged 1 commit intocontainerd:release/1.1from
Random-Liu:cherrypick-#2769-release-1.1

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

Cherrypick of #2769.
For #2709.

Only v1 change is cherry-picked.

Signed-off-by: Wei Fu [email protected]

1. avoid dead lock during kill, fetch allProcesses before handle events
2. use argu's ctx instead of context.Backgroud() in openlog

Signed-off-by: Wei Fu <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2774 into release/1.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.1    #2774   +/-   ##
============================================
  Coverage        48.99%   48.99%           
============================================
  Files               85       85           
  Lines             7603     7603           
============================================
  Hits              3725     3725           
  Misses            3203     3203           
  Partials           675      675
Flag Coverage Δ
#linux 48.99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b337430...665815b. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants