Merged
Conversation
This was referenced Nov 6, 2018
ca7b3a6 to
1205cee
Compare
AkihiroSuda
commented
Nov 6, 2018
docs/rootless.md
Outdated
1205cee to
04b441b
Compare
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
04b441b to
ce6d4c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 47.39% 43.72% -3.68%
==========================================
Files 91 100 +9
Lines 8415 10734 +2319
==========================================
+ Hits 3988 4693 +705
- Misses 3704 5311 +1607
- Partials 723 730 +7
Continue to review full report at Codecov.
|
Member
|
LGTM |
Contributor
|
Awesome! |
Member
Author
|
PR for CRI plugin: containerd/cri#970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change on the daemon side at all. (CRI plugin will support "cgroupless" configuration in a separate PR)
Replaces #2006
Closes #2262
Relates to moby/moby#38050