Skip to content

Change unsupported snapshot warnings to INFO#2745

Merged
crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael:snapshot-warnings
Oct 26, 2018
Merged

Change unsupported snapshot warnings to INFO#2745
crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael:snapshot-warnings

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Since there is no real action the user can do, these can safely be
informative that the underlying filesystem does not support a snapshot
plugin at boot.

Signed-off-by: Michael Crosby [email protected]

Since there is no real action the user can do, these can safely be
informative that the underlying filesystem does not support a snapshot
plugin at boot.

Signed-off-by: Michael Crosby <[email protected]>
@crosbymichael crosbymichael added this to the 1.2.1 milestone Oct 26, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 26, 2018

Codecov Report

Merging #2745 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
- Coverage   43.74%   43.73%   -0.01%     
==========================================
  Files         100      100              
  Lines       10728    10730       +2     
==========================================
  Hits         4693     4693              
- Misses       5305     5307       +2     
  Partials      730      730
Flag Coverage Δ
#linux 47.41% <0%> (-0.01%) ⬇️
#windows 40.89% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
services/server/server.go 1.65% <0%> (-0.02%) ⬇️
snapshots/btrfs/btrfs.go 57.39% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c444666...1301813. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

LGTM

1.1 backport as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants