Skip to content

Prepare 1.2 release#2731

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:release-1.2
Oct 24, 2018
Merged

Prepare 1.2 release#2731
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:release-1.2

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Oct 18, 2018

Update release document and release notes for 1.2

Still some additions that need to be made to the release notes

  • Enumerate "minor API changes"
  • mention ctr incompatibilities @AkihiroSuda

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 18, 2018

Codecov Report

Merging #2731 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2731   +/-   ##
=======================================
  Coverage   43.74%   43.74%           
=======================================
  Files         100      100           
  Lines       10728    10728           
=======================================
  Hits         4693     4693           
  Misses       5305     5305           
  Partials      730      730
Flag Coverage Δ
#linux 47.41% <ø> (ø) ⬆️
#windows 40.92% <ø> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20c569...e4d2486. Read the comment docs.

@AkihiroSuda
Copy link
Copy Markdown
Member

mention cri incompatibilities @AkihiroSuda

cc @Random-Liu

Comment thread releases/v1.2.0.toml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also mention ctr images import CLI incompatibility, although it is out of scope of the support.

@dmcgowan
Copy link
Copy Markdown
Member Author

@AkihiroSuda I read your initial comment wrong, the mention was for ctr incompatibilities. Is it just with import?

@AkihiroSuda
Copy link
Copy Markdown
Member

Is it just with import?

Yes, AFAIK

@Random-Liu
Copy link
Copy Markdown
Member

Can we add this into cri "Notable Changes"?

* An runtime `options` field is added. For shim v2 runtime, use the `options` field to config runtime specific options, e.g. `NoPivotRoot` and `SystemdCgroup` for runtime type `io.containerd.runc.v1`. (See [config.md](https://github.com/containerd/cri/blob/release/1.2/docs/config.md))

@dmcgowan
Copy link
Copy Markdown
Member Author

Updated, please review!

@Random-Liu
Copy link
Copy Markdown
Member

CRI note update LGTM.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@dmcgowan dmcgowan added this to the 1.2 milestone Oct 24, 2018
Rename release notes to remove rc label.
Add 1.2 API description text file.
Update version.

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan merged commit c444666 into containerd:master Oct 24, 2018
@dmcgowan dmcgowan deleted the release-1.2 branch September 10, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants