Prepare 1.2 release#2731
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Oct 24, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2731 +/- ##
=======================================
Coverage 43.74% 43.74%
=======================================
Files 100 100
Lines 10728 10728
=======================================
Hits 4693 4693
Misses 5305 5305
Partials 730 730
Continue to review full report at Codecov.
|
Member
cc @Random-Liu |
AkihiroSuda
reviewed
Oct 19, 2018
Member
There was a problem hiding this comment.
Maybe we can also mention ctr images import CLI incompatibility, although it is out of scope of the support.
Member
Author
|
@AkihiroSuda I read your initial comment wrong, the mention was for ctr incompatibilities. Is it just with import? |
Member
Yes, AFAIK |
Member
|
Can we add this into |
Member
Author
|
Updated, please review! |
Member
|
CRI note update LGTM. |
AkihiroSuda
approved these changes
Oct 24, 2018
Member
|
LGTM |
Rename release notes to remove rc label. Add 1.2 API description text file. Update version. Signed-off-by: Derek McGowan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update release document and release notes for 1.2
Still some additions that need to be made to the release notes