allow idempotence when adding a task to cgroup metrics collection#2727
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Oct 18, 2018
mikebrow:ignore-idempotence
Merged
allow idempotence when adding a task to cgroup metrics collection#2727dmcgowan merged 1 commit intocontainerd:masterfrom mikebrow:ignore-idempotence
dmcgowan merged 1 commit intocontainerd:masterfrom
mikebrow:ignore-idempotence
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2727 +/- ##
=======================================
Coverage 43.75% 43.75%
=======================================
Files 100 100
Lines 10725 10725
=======================================
Hits 4693 4693
Misses 5301 5301
Partials 731 731
Continue to review full report at Codecov.
|
mikebrow
changed the title
mikebrow
changed the title
Member
Author
|
Moby test-integration passing: |
Signed-off-by: Mike Brown <[email protected]>
AkihiroSuda
approved these changes
Oct 18, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, but it would be great if we can have test in this repo as well (can be separate PR for v1.2.1)
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue/comment:
moby/moby#37932 (comment)
by allowing idempotence when adding a task to cgroups metrics collection...
Signed-off-by: Mike Brown [email protected]