Skip to content

ctr: add some metric item#2721

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
Ace-Tang:master
Oct 16, 2018
Merged

ctr: add some metric item#2721
crosbymichael merged 1 commit intocontainerd:masterfrom
Ace-Tang:master

Conversation

@Ace-Tang
Copy link
Copy Markdown
Contributor

@Ace-Tang Ace-Tang commented Oct 16, 2018

add memory limit, pid info into metric subcommand, since moby also
show them. As blkio read/write IO need more calculation，not add them.

Signed-off-by: Ace-Tang [email protected]

after this patch, format like:

$ sudo bin/ctr t metric vv2
ID     TIMESTAMP                                  
vv2    2018-10-16 08:59:13.749647292 +0000 UTC    

METRIC                   VALUE                               
memory.usage_in_bytes    376832                              
memory.limit_in_bytes    9223372036854771712                 
memory.stat.cache        331776                              
cpuacct.usage            12810199                            
cpuacct.usage_percpu     [1712085 2246486 437550 8414078]    
pids.current             1                                   
pids.limit               0

Seems the table format only show some needed item, I just think to add some item which moby also show with docker stats. As blkio read/write IO need more calculation，not add them follow the logic here.

@Ace-Tang
ctr: add some metric item
7ea75ef 
add memory limit, pid info into metric subcommand, since moby also
show them. As blkio read/write IO need more calculation，not add them.

Signed-off-by: Ace-Tang <[email protected]>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 16, 2018 •
edited
Loading

Codecov Report

Merging #2721 into master will decrease coverage by 3.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
- Coverage   47.34%   43.68%   -3.67%     
==========================================
  Files          92      101       +9     
  Lines        8423    10744    +2321     
==========================================
+ Hits         3988     4693     +705     
- Misses       3711     5320    +1609     
- Partials      724      731       +7
Flag Coverage Δ
#linux 47.34% <ø> (ø) ⬆️
#windows 40.83% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 57.84% <0%> (-6.36%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
remotes/docker/resolver.go 58.36% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc3b83...7ea75ef. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Oct 16, 2018

LGTM

@crosbymichael crosbymichael merged commit 9fe52f6 into containerd:master Oct 16, 2018
@thaJeztah thaJeztah mentioned this pull request Oct 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ace-Tang @codecov-io @crosbymichael @AkihiroSuda