Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stress test for image config opt requirements #2720

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Fix stress test for image config opt requirements #2720

merged 1 commit into from
Oct 16, 2018

Conversation

crosbymichael
Copy link
Member

Signed-off-by: Michael Crosby [email protected]

@andrewhsu
Copy link

Works for me.

Without this fix:

$ sudo ./containerd-stress -c 4 -d 10s
INFO[0000] pulling docker.io/library/alpine:latest      
INFO[0000] generating spec from image                   
INFO[0000] starting stress test run...                  
rootfs absolute path is required

With this fix:

$ sudo ./containerd-stress -c 4 -d 10s
INFO[0000] pulling docker.io/library/alpine:latest      
INFO[0000] starting stress test run...                  
INFO[0010] worker 0 finished                            
INFO[0010] worker 3 finished                            
INFO[0011] worker 1 finished                            
INFO[0011] worker 2 finished                            
INFO[0011] ending test run in 10.200 seconds            
INFO[0011] create/start/delete 104 containers in 10.200 seconds (10.196 c/sec) or (0.098 sec/c)  failures=0

@dmcgowan
Copy link
Member

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2720   +/-   ##
=======================================
  Coverage   43.54%   43.54%           
=======================================
  Files         101      101           
  Lines       10734    10734           
=======================================
  Hits         4674     4674           
  Misses       5326     5326           
  Partials      734      734
Flag Coverage Δ
#linux 47.2% <ø> (-0.03%) ⬇️
#windows 40.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d725ebe...e86a068. Read the comment docs.

estesp
estesp approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael crosbymichael merged commit fdc4e1f into containerd:master Oct 16, 2018
@crosbymichael crosbymichael deleted the stress-root branch October 16, 2018 01:17
@thaJeztah thaJeztah mentioned this pull request Oct 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crosbymichael @andrewhsu @dmcgowan @codecov-io @estesp