Set uncompressed label on diff when already exists#2717
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Oct 15, 2018
Merged
Set uncompressed label on diff when already exists#2717crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Diff expects to set the uncompressed label on Commit, however if the blob already exists in the content store, no labels will get set, requiring an Update. Check if the uncompressed label is on the blob and set it if not. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2717 +/- ##
=======================================
Coverage 43.54% 43.54%
=======================================
Files 101 101
Lines 10734 10734
=======================================
Hits 4674 4674
Misses 5326 5326
Partials 734 734
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff expects to set the uncompressed label on Commit, however if the blob already exists in the content store no labels will get set, requiring an Update. Check if the uncompressed label is on the blob and set it if not.
Fixes #2707