enhance: support specific duration for profile collection#2710
Merged
estesp merged 1 commit intocontainerd:masterfrom Oct 11, 2018
Merged
Conversation
The default duration of cpu profile collection in net/http/pprof is 30 seconds. User should have chance to set the specific duration for the collection. Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
=======================================
Coverage 43.54% 43.54%
=======================================
Files 101 101
Lines 10734 10734
=======================================
Hits 4674 4674
Misses 5326 5326
Partials 734 734
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Oct 11, 2018
fuweid
deleted the
enhance_support_duration_for_cpu_profile_collection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default duration of cpu profile collection in net/http/pprof is 30
seconds. User should have chance to set the specific duration for the
collection.
Signed-off-by: Wei Fu [email protected]