Skip AdditionalGID's for LCOW oci spec#2698
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Oct 3, 2018
Merged
Conversation
Signed-off-by: Justin Terry (VM) <[email protected]>
Contributor
Author
|
This commit fixes the ability to run LCOW via CTR. C:\> ctr image pull --snapshotter windows-lcow --platform linux/amd64 docker.io/library/alpine:latest
C:\> ctr run --runtime io.containerd.runhcs.v1 --snapshotter windows-lcow --rm docker.io/library/alpine:latest lcow-test sh -c "echo Hello World!"
Hello World! |
Codecov Report
@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
- Coverage 43.6% 43.59% -0.02%
==========================================
Files 101 101
Lines 10718 10722 +4
==========================================
Hits 4674 4674
- Misses 5310 5314 +4
Partials 734 734
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Terry (VM) [email protected]