Various runhcs shim fixes#2692
Merged
estesp merged 5 commits intocontainerd:masterfrom Oct 3, 2018
Merged
Conversation
mlaventure
reviewed
Oct 1, 2018
Contributor
There was a problem hiding this comment.
nit: could be simplified to
if gruntime.GOOS != "windows" {
bundlePath = b.bundle.Path
}
Contributor
There was a problem hiding this comment.
typo: s/deafult/default/
jterry75
force-pushed
the
shim_reconnect
branch
3 times, most recently
from
cc2bbb1 to
fd083f8
Compare
Contributor
|
One more issue, but LGTM. There seems to be some unwanted whitespaces |
Signed-off-by: Justin Terry (VM) <[email protected]>
On Windows because of the way the log pipe is forwarded to the shim there is a condition where the pipe listener may not yet be active when a client tries to connect. To handle this case we allow polling on the file and rety on pipe not found. This limits the pipe not found retry to 5 seconds but leaves the connect timeout alone as if there is a listener we want to connect to it normally. Signed-off-by: Justin Terry (VM) <[email protected]>
Signed-off-by: Justin Terry (VM) <[email protected]>
Signed-off-by: Justin Terry (VM) <[email protected]>
Signed-off-by: Justin Terry (VM) <[email protected]>
jterry75
force-pushed
the
shim_reconnect
branch
from
fd083f8 to
ab20312
Compare
Contributor
Author
|
@mlaventure - Can you tell me what the build failure was? This builds/tests/verifies locally just fine. Do you have any ideas? |
Codecov Report
@@ Coverage Diff @@
## master #2692 +/- ##
=========================================
+ Coverage 43.07% 44.5% +1.42%
=========================================
Files 100 101 +1
Lines 10606 10918 +312
=========================================
+ Hits 4569 4859 +290
+ Misses 5316 5307 -9
- Partials 721 752 +31
Continue to review full report at Codecov.
|
Member
|
the whitespace error was fixed on the last push; CI passing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows because of the way the log pipe is forwarded to the shim there is a
condition where the pipe listener may not yet be active when a client tries to
connect. To handle this case we allow polling on the file and retry on pipe not
found. This limits the pipe not found retry to 5 seconds but leaves the connect
timeout alone as if there is a listener we want to connect to it normally.