bugfix: cache empty layer for docker schema1 image#2691
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Oct 15, 2018
Merged
bugfix: cache empty layer for docker schema1 image#2691crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael merged 2 commits intocontainerd:masterfrom
Conversation
containerd should cache empty label for docker schema1 image. if not, the original empty layer will be non-empty layer and the image config will be changed too. in this case, the image ID will be changed. check the blob empty label to avoid changing image ID when repull docker schema1 image. Signed-off-by: Wei Fu <[email protected]>
Member
Author
|
I use the following script to test it. |
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
- Coverage 45.09% 43.54% -1.56%
==========================================
Files 92 101 +9
Lines 10132 10734 +602
==========================================
+ Hits 4569 4674 +105
- Misses 4842 5326 +484
- Partials 721 734 +13
Continue to review full report at Codecov.
|
Member
|
Change looks good, trying to figure out if the key name is ok or needs to follow a different pattern. I will make sure this gets into rc.2 or 1.2 final though. |
Signed-off-by: Derek McGowan <[email protected]>
Member
|
I pushed a change with a small label update LGTM on green |
Member
|
LGTM |
Member
Author
|
Thank you! @dmcgowan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerd should cache empty label for docker schema1 image.
if not, the original empty layer will be non-empty layer and the image
config will be changed too. in this case, the image ID will be changed.
check the blob empty label to avoid changing image ID when repull docker
schema1 image.
Signed-off-by: Wei Fu [email protected]
#2678