Update manifest resolution for non-index manifests#2684
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Sep 27, 2018
Merged
Update manifest resolution for non-index manifests#2684crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Avoid filtering manifests by platform when a non-index manifest is provided to the Manifest function. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
======================================
Coverage 45% 45%
======================================
Files 92 92
Lines 10114 10114
======================================
Hits 4552 4552
Misses 4842 4842
Partials 720 720
Continue to review full report at Codecov.
|
estesp
approved these changes
Sep 26, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; seems reasonable until there is some future way to truly control image config platform details (cross-building has never been supported in docker build semantics.. you always get the build system os/arch in the image config)
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid filtering manifests by platform when a non-index manifest is provided to the Manifest function.
This came up as an issue on ARM machines that rely on images marked as amd64 but with no platform-specific functionality. I am open to suggestions for better ways to support this. The only other options I could think of would be a confusing flag or throwing a more helpful error which the client would need to interpret and retry without platform.